Fix a false positive for Style/StringLiterals
#10229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to rubocop#10166 (comment). This PR fixes a false positive for `Style/StringLiterals` when `EnforcedStyle: double_quotes` and using single quoted string with backslash. It has moved a separate implementation for `Style/QuotedSymbols` to resolve rubocop#10152 to `Style/QuotedSymbols` to prevent impact on `Style/StringLiterals`'s false positives.
8 tasks
|
Awesome. FWIW this fixes all the false positives we were seeing in #10166 (comment) |
dvandersluis
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #10166 (comment).
This PR fixes a false positive for
Style/StringLiteralswhenEnforcedStyle: double_quotesand using single quoted string with backslash.It has moved a separate implementation for
Style/QuotedSymbolsto resolve #10152 toStyle/QuotedSymbolsto prevent impact onStyle/StringLiterals's false positives.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.